Conversation
rfultz
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6793 +/- ##
========================================
Coverage 79.17% 79.17%
========================================
Files 255 255
Lines 6544 6544
========================================
Hits 5181 5181
Misses 1363 1363 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@rfultz Two changes from Ryan, both on the allocating question:
No other changes. Once that's done I can approve. |
JonellaCulmer
left a comment
JonellaCulmer
left a comment
There was a problem hiding this comment.
This looks great! Thank you for the last-minute changes on the allocating screen.
| this.plansToAllocate = undefined; | ||
| this.showHelp = false; | ||
| // Set all the frames to not viewed (for breadcrumbs and Next button) | ||
| this.frames.forEach(frame => {frame.viewed.false;}); |
There was a problem hiding this comment.
After I reach the end and click "Start over", I could move forward by clicking the "Next" button without even answering the questions. It's because the syntax is off here, should be this.frames.forEach(frame => {frame.viewed = false;});.
6 participants
Summary
Initial build for the FECfile+ eligibility widget
Required reviewers
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
Related PRs
None
How to test
CMS
<button class="button button--cta button--go js-launch-fecfile-eligibility">Launch!</button>(Thejs-launch-fecfile-eligibilityclass is the important part)(I used
http://127.0.0.1:8000/help-candidates-and-committees/filing-reports/electronic-filing/getting-started-fecfile-pilot/because it seemed to make sense)Code
npm inpm run build<dialog>should open?dialog=openand hit Enter<dialog>should start in an open state